Protocol Fee Table #964
Merged
Protocol Fee Table #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zajck
requested changes
Oct 2, 2024
levalleux-ludo
requested changes
Nov 14, 2024
| // If the token has a custom fee table, find the appropriate percentage | ||
| uint256 priceRangesLength = priceRanges.length; | ||
| if (priceRangesLength > 0) { | ||
| for (uint256 i; i < priceRangesLength; ++i) { |
There was a problem hiding this comment.
Suggested change
| for (uint256 i; i < priceRangesLength; ++i) { | |
| for (uint256 i; i < priceRangesLength - 1; ++i) { |
I guess it should give the same result saving a few instruction/gas (at least 1 if() assessment)
| */ | ||
| function setTokenPriceRanges(address _tokenAddress, uint256[] calldata _priceRanges) internal { | ||
| for (uint256 i = 1; i < _priceRanges.length; ++i) { | ||
| if (_priceRanges[i] < _priceRanges[i - 1]) revert NonAscendingOrder(); |
There was a problem hiding this comment.
Suggested change
| if (_priceRanges[i] < _priceRanges[i - 1]) revert NonAscendingOrder(); | |
| if (_priceRanges[i] <= _priceRanges[i - 1]) revert NonAscendingOrder(); |
I don't think it makes sense to accept 2 successive ranges with the same value
There was a problem hiding this comment.
Makes sense. Fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #956